Add JustKnobs to TSC CUPTI Callback #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
57e07eb
to
bf4f324
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
force-pushed
the
export-D58485370
branch
from
bf4f324
to
b0a4562
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
b0a4562
to
5fd764f
Compare
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
5fd764f
to
e7c711f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 14, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
e7c711f
to
6fda281
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 14, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
6fda281
to
e66fdfb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 14, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
e66fdfb
to
081886e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 14, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
081886e
to
60f1577
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jun 17, 2024
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Reviewed By: aaronenyeshi Differential Revision: D58485370
sraikund16
force-pushed
the
export-D58485370
branch
from
60f1577
to
8c79205
Compare
Summary: Pull Request resolved: pytorch#947 Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch. On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header. Reviewed By: aaronenyeshi Differential Revision: D58485370
|
This pull request was exported from Phabricator. Differential Revision: D58485370 |
sraikund16
force-pushed
the
export-D58485370
branch
from
8c79205
to
4803a6d
Compare
aaronenyeshi
approved these changes
Jun 17, 2024
|
This pull request has been merged in 36c2a78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add JustKnobs so that we can turn TSC CUPTI Callback on and off. Since we need to meet open source compliance, we need to first add a default value of true in the Config class. In the FBConfig class we then add a method that checks the JK and overrides the default value of true. We also add a static variable to the CuptiActivityProfiler which will be overriden by the Config value upon initialization. Once this is set, the profiler as well as all headers will use the flag that was set by the JK. Using this flag we can essentially use the TSC timestamp or system clock via killswitch. Since the JK can run asynchronously across many initializations, wrap it in a try/catch.
On top of this change, ApproximateClock is moved from src/ to include/. This is because it is a forward facing header so it makes sense to expose it as a public header. Added also to the bazel file as a public header.
Differential Revision: D58485370