Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of incorrect External id for non-PyTorch activities #1001

Closed
wants to merge 4 commits into from
+21 −5
Closed

Fix the issue of incorrect External id for non-PyTorch activities #1001

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0288bad
Fix the issue of incorrect External id for non-PyTorch activities
Oct 12, 2024
d238343
use exclude list
Oct 21, 2024
12a06fa
Merge branch 'main' into correct_external_id
sraikund16 Oct 21, 2024
c4415e7
lint
sraikund16 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions libkineto/src/output_json.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,28 @@ void ChromeTraceLogger::handleActivity(const libkineto::ITraceActivity& op) {
duration += 2; // Still need it to end at the original point rounded up.
}

int external_id = 0;
if (op.linkedActivity()) {
external_id = op.linkedActivity()->correlationId();
} else {
// Some runtime events and kernels may not have a linked activity,
// should not set an "External id" for them. Otherwise, these events
// may be incorrectly linked to the other external events.
static const std::set<libkineto::ActivityType> excludedTypes = {
libkineto::ActivityType::GPU_MEMCPY,
libkineto::ActivityType::GPU_MEMSET,
libkineto::ActivityType::CONCURRENT_KERNEL,
libkineto::ActivityType::CUDA_RUNTIME,
libkineto::ActivityType::CUDA_DRIVER,
libkineto::ActivityType::PRIVATEUSE1_RUNTIME,
libkineto::ActivityType::PRIVATEUSE1_DRIVER};
if (excludedTypes.find(op.type()) == excludedTypes.end()) {
external_id = op.correlationId();
}
}
std::string arg_values = "";
if (op.linkedActivity() && op.linkedActivity()->correlationId() != 0) {
arg_values.append(fmt::format(
"\"External id\": {}", op.linkedActivity()->correlationId()));
} else if (op.correlationId() != 0) {
arg_values.append(fmt::format("\"External id\": {}", op.correlationId()));
if (external_id != 0) {
arg_values.append(fmt::format("\"External id\": {}", external_id));
}
std::string op_metadata = op.metadataJson();
sanitizeStrForJSON(op_metadata);
Expand Down
Loading