compute_smoothed_constraint_indicator -> compute_smoothed_feasibility_indicator
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47436246 |
Summary: Pull Request resolved: pytorch#1931 This commit separates out the `compute_best_feasible_f` function from `qNEI` as a utility function in order to use it in the `input_constructors` and `get_acquisition_function` (follow-up). Differential Revision: https://internalfb.com/D47365085 fbshipit-source-id: c2bcf88c7c28a9230490f662d61b40eab6bab68c
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Differential Revision: https://internalfb.com/D47365084 fbshipit-source-id: 6422ddeabde2cd9804b1e76e25236e2021f8c1a2
…ity_indicator` (pytorch#1935) Summary: Pull Request resolved: pytorch#1935 D47365085 introduced the aptly named `compute_feasibility_indicator`. This commit brings the smoothed counterpart in alignment with the naming convention. Reviewed By: Balandat Differential Revision: D47436246 fbshipit-source-id: 5612b1cbb69993b475702779f62bb2cbfada9c96
SebastianAment
force-pushed
the
export-D47436246
branch
from
67b6ad4
to
538bbc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47436246 |
Codecov Report
@@ Coverage Diff @@
## main #1935 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 176 176
Lines 15480 15500 +20
=======================================
+ Hits 15472 15492 +20
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in d333163. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D47365085 introduced the aptly named
compute_feasibility_indicator. This commit brings the smoothed counterpart in alignment with the naming convention.Differential Revision: D47436246