Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

einsum for LCEAKernel #1918

Closed
wants to merge 1 commit into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit fixes the einsum indexing in the forward pass of the LCEAKernel.

Reviewed By: sdaulton

Differential Revision: D47226145

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jul 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47226145

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Jul 5, 2023
Summary:
Pull Request resolved: pytorch#1918

This commit fixes the `einsum` indexing in the forward pass of the `LCEAKernel`.

Reviewed By: sdaulton

Differential Revision: D47226145

fbshipit-source-id: d92ab3ca1e972a62e8b25998d24a7ad6fac4a558
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47226145

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Jul 5, 2023
Summary:
Pull Request resolved: pytorch#1918

This commit fixes the `einsum` indexing in the forward pass of the `LCEAKernel`.

Reviewed By: sdaulton

Differential Revision: D47226145

fbshipit-source-id: f92c519759cdb43513b0e472701e31223be8242a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47226145

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1918 (9d11d83) into main (f6ed868) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9d11d83 differs from pull request most recent head e555602. Consider uploading reports for the commit e555602 to get more accurate results

@@            Coverage Diff            @@
##              main     #1918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines        15270     15271    +1     
=========================================
+ Hits         15270     15271    +1     
Impacted Files Coverage Δ
botorch/models/kernels/contextual_lcea.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Summary:
Pull Request resolved: pytorch#1918

This commit fixes the `einsum` indexing in the forward pass of the `LCEAKernel`.

Reviewed By: sdaulton

Differential Revision: D47226145

fbshipit-source-id: 28732dfb050e77feab4f1c05af2ecaf35b85132c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47226145

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5bf06d7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants