Use xargs over find -exec to ensure exit code is returned properly #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLovering
force-pushed
the
update-eval-deps-script
branch
from
44044c1
to
083fbba
Compare
ChrisLovering
force-pushed
the
update-eval-deps-script
branch
from
083fbba
to
765f419
Compare
|
forcepush was to reword the commit description to be clearer. |
Running this script in it's previous form (via `docker compose run`) always returned an exit code of 0. This is due to `find` always returning a 0 exit code, unless an error occurred while traversing the directories.
MarkKoz
force-pushed
the
update-eval-deps-script
branch
from
765f419
to
324f74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this script in it's previous form (via
docker compose run) always returned an exit code of 0. This is due tofindalways returning a 0 exit code, unless an error occurred while traversing the directories.This caused CI to always report a success when isntalling deps, even when pip failed.