Create an admin task when votes are 2 weeks old #2323

shtlrs · 2022-11-12T16:35:38Z

The idea is to fetch active nominations that are more than 2 weeks old, and create admin issues for them in Github so that staff will do the follow up.

As soon as a vote is tracked, we add a "🎫" reaction (which can change) to it to make sure we don't create duplicate issues for it, instead of keeping track in another way

…old-votes-in-github

This will allow us to avoid looking for the message again since we'll need it to add a reaction

shtlrs · 2022-11-12T16:39:22Z

@ChrisLovering Here's a draft PR for #2226.

The only missing part is the Github issue part since i'm not quite aware of the repo/project structure for admins.
I suppose it needs to be configured from out config.yml file ?

Note
I had to merge my unfinished PR into this to make sure we easily access nomination history.
I made the commits "atomic" to facilitate creating a new PR with a cleaner git history

HassanAbouelela · 2022-11-12T19:08:19Z

Fwiw, you can target one PR to another branch (i.e it would look something like main <- nomination history PR branch <- this PR branch).

What that would do is basically try applying the changes from the final branch (3) in this chain to the middle branch (2), so when you check out the 3rd branch, it would have all the changes from branch 2 as well, but the PR itself will only have the changes of branch 3.

For the admin repo, there's an issue template which Chris can probably fetch for ya. The template body is completely unmodified at issue creation, we just set the nominated user as the issue title. You can use this API to create the issue (as far as I can tell the API doesn't expose a way to create an issue from a template), which you'll need a token with access for. Simply add that as an environment variable in the default-config file (example), and the devops team will worry about getting it set, just ping us to do so when the PR is ready.

Also please have a sensible default behavior for development environments where that token is unlikely to be set/exist.

shtlrs · 2022-11-12T21:38:59Z

@HassanAbouelela Thanks for the tip, I didn't know that was feasible.

I see that we already have a keys section in our config, and we have a GitHub key as well but I think we'll need a new one because of permission levels, so I'll add a new key for it.

As for the default behavior, I have just thought of a warning log and an early return when that value of that key is null.

shtlrs · 2022-11-13T18:11:57Z

A couple of points to discuss when I publish this PR:

Upon creating an issue and when a member is not found, should we delete the nomination ?
We need to update our contribution guide to detail the new config that needs to be added in case someone wants to use/test the feature, right ?

The issue template/content/title is still to be discussed

config-default.yml

ChrisLovering · 2022-11-26T16:55:45Z

bot/exts/recruitment/talentpool/_review.py

+        threads = [await get_or_fetch_channel(nomination.thread_id) for nomination in history]
+
+        nomination_vote_threads = ", ".join(
+            [
+                f"[Thread-{thread_number}]({thread.jump_url})" if thread else ''
+                for thread_number, thread in enumerate(threads, start=1)
+            ]
+        )


This change doesn't seem related to the issue, so might be worth splitting to another PR, since there's some more logic you'll need here.

get_or_fetch_channel will raise an error if the channel isn't found, rather than returning None that you are assuming here.

In your nomination_vote_threads list comp if the thread is non, you're adding '', which will result in odd output since, it will still add the comma separator.

That change is due to the fact that my other PR that hasn't been merged is needed, so I merged it here.
When it does get merged, I'll clean up the history.

I think commit e68d756 should hold the answer

And now that my previously mentioned PR has been merged, these changes no longer exist
Merge happened here 59319b4

ChrisLovering · 2022-11-26T16:56:06Z

bot/exts/recruitment/talentpool/_cog.py

+        thread = None
+
+        if nomination.thread_id:
+            thread = await get_or_fetch_channel(nomination.thread_id)


Handle the case where this raises an error if the thread doesn't exist.

That's actually handled in the original PR that adds the thread id to the nominations table.

Should be visible in e68d756

bot/exts/recruitment/talentpool/_cog.py

ChrisLovering · 2022-11-26T16:58:12Z

bot/exts/recruitment/talentpool/_cog.py

+            if issue_created:
+                await nomination_vote_message.add_reaction(FLAG_EMOJI)
+
+    async def _get_forgotten_nominations(self) -> List[Nomination]:


Suggested change

async def _get_forgotten_nominations(self) -> List[Nomination]:

async def _get_forgotten_nominations(self) -> list[Nomination]:

This can be done since Python 3.9. There are more examples in this PR where typing is used where built-ins could be used instead, please replace them.

Done in 68c625c

This isn't resolved.

ChrisLovering · 2022-11-26T17:01:39Z

bot/exts/recruitment/talentpool/_cog.py

+            self,
+            nominations: List[Nomination]
+    ) -> List[Tuple[Nomination, discord.Message]]:
+        """Filter the forgotten nominations that are still untracked in GitHub."""


This isn't just a filter, since it returns more data that it was given. This should be described in the docstring, and maybe change the function name to make it clear it isn't just a filter

Alrighty, fixed in 1c8059a

This isn't resolved.

ChrisLovering · 2022-11-26T17:02:33Z

bot/exts/recruitment/talentpool/_cog.py

+        Returns True when the issue has been created, False otherwise.
+        """
+        if not GithubAdminRepo.token:
+            log.warn(f"No token for the {GithubAdminRepo.name} repository was provided, skipping issue creation.")


Suggested change

log.warn(f"No token for the {GithubAdminRepo.name} repository was provided, skipping issue creation.")

log.warning(f"No token for the {GithubAdminRepo.name} repository was provided, skipping issue creation.")

warn is a deprecated alias to warning

This isn't resolved.

Done in 3ca37a0

bot/exts/recruitment/talentpool/_cog.py

ChrisLovering · 2022-11-26T17:05:01Z

A couple of points to discuss when I publish this PR:
1. Upon creating an issue and when a member is not found, should we delete the nomination ?

2. We need to update our contribution guide to detail the new config that needs to be added in case someone wants to use/test the feature, right ?
The issue template/content/title is still to be discussed

Not in this PR, that can be discussed in a separate issue.
Yea, that can be another PR to site after this is merged

…ations

…ng tracked nominations

# Conflicts: # bot/exts/recruitment/talentpool/_cog.py # bot/exts/recruitment/talentpool/_review.py

shtlrs · 2022-11-14T07:33:57Z

bot/exts/recruitment/talentpool/_cog.py

@@ -43,6 +49,7 @@ def __init__(self, bot: Bot) -> None:

    async def cog_load(self) -> None:
        """Start autoreview loop if enabled."""
+        self.track_forgotten_nominations.start()


Should we make this configurable to run just like we do for autoreview ?

shtlrs · 2022-11-26T17:11:12Z

bot/exts/recruitment/talentpool/_review.py

+        threads = [await get_or_fetch_channel(nomination.thread_id) for nomination in history]
+
+        nomination_vote_threads = ", ".join(
+            [
+                f"[Thread-{thread_number}]({thread.jump_url})" if thread else ''
+                for thread_number, thread in enumerate(threads, start=1)
+            ]
+        )


That change is due to the fact that my other PR that hasn't been merged is needed, so I merged it here.
When it does get merged, I'll clean up the history.

bot/exts/recruitment/talentpool/_cog.py

shtlrs · 2022-11-27T11:24:40Z

bot/exts/recruitment/talentpool/_cog.py

+            starter_message = thread.starter_message
+            if not starter_message:
+                # Starter message will be null if it's not cached
+                starter_message = await self.bot.get_channel(Channels.nomination_voting).fetch_message(thread.id)


Fixed in 5a916ac

shtlrs · 2022-11-27T12:18:00Z

bot/exts/recruitment/talentpool/_cog.py

+        Returns True when the issue has been created, False otherwise.
+        """
+        if not GithubAdminRepo.token:
+            log.warn(f"No token for the {GithubAdminRepo.name} repository was provided, skipping issue creation.")


Done in 3ca37a0

bot/exts/recruitment/talentpool/_cog.py

shtlrs · 2022-11-27T12:26:20Z

bot/exts/recruitment/talentpool/_cog.py

+        thread = None
+
+        if nomination.thread_id:
+            thread = await get_or_fetch_channel(nomination.thread_id)


Should be visible in e68d756

shtlrs · 2022-11-27T12:29:21Z

bot/exts/recruitment/talentpool/_review.py

+        threads = [await get_or_fetch_channel(nomination.thread_id) for nomination in history]
+
+        nomination_vote_threads = ", ".join(
+            [
+                f"[Thread-{thread_number}]({thread.jump_url})" if thread else ''
+                for thread_number, thread in enumerate(threads, start=1)
+            ]
+        )


I think commit e68d756 should hold the answer

shtlrs · 2023-01-01T17:16:01Z

bot/exts/recruitment/talentpool/_review.py

+        threads = [await get_or_fetch_channel(nomination.thread_id) for nomination in history]
+
+        nomination_vote_threads = ", ".join(
+            [
+                f"[Thread-{thread_number}]({thread.jump_url})" if thread else ''
+                for thread_number, thread in enumerate(threads, start=1)
+            ]
+        )


And now that my previously mentioned PR has been merged, these changes no longer exist
Merge happened here 59319b4

bot/exts/recruitment/talentpool/_cog.py

This relies on turning the thread snowflake id into a date time We then use that for comparison, since an existing active thread id means an existing review

shtlrs · 2023-04-20T21:34:21Z

Closing in favor of #2553

Amrou Bellalouna added 15 commits November 6, 2022 09:28

add thread_id to pydantic model

4f235c8

add thread mentions to review history

b1845e5

add list of threads to a review's markdown file

99d9662

replace thread mention with jump url

18e7cbe

add style to thread not found message

71d6ebc

use get_or_fetch_channel to look from thread

293dac8

use jump_url in the review markdown file

f6f3e55

add emtpy task to track forgotten nominations

33828c8

fetch forgotten nominations from site

ecc29bd

filter out untracked nominations in GitHub

8bd6840

Merge branch '2304-link-previous-nomination-threads' into 2226-track-…

c4be56d

…old-votes-in-github

filter out untracked nominations in GitHub

346be1a

return a nominationXMessage tuple

ed728d4

This will allow us to avoid looking for the message again since we'll need it to add a reaction

add dummy method that tracks vote in GitHub

506fbb2

use "🎫" as emoji

0ba1ddf

Amrou Bellalouna added 3 commits November 13, 2022 13:29

add github_admin_repo section

9773aca

add loader for the github_admin_repo section

0da9f16

log repo name when token hasn't been provided

fef37fe

reset value of autoreview task

9259f84

shtlrs marked this pull request as ready for review November 13, 2022 18:30

shtlrs requested a review from wookie184 as a code owner November 13, 2022 18:30

ChrisLovering self-requested a review November 25, 2022 23:52

ChrisLovering requested changes Nov 26, 2022

View reviewed changes

shtlrs added 2 commits November 27, 2022 12:01

change repo name to 'admin-tasks'

161df87

add debug log upon creating Github issue

4b0d49b

shtlrs added 6 commits November 27, 2022 12:15

handle case where member cannot be found upon tracking vote

154c51d

handle case where thread cannot be found when filtering tracked nomin…

802003b

…ations

handle case where thread starter message cannot be found when filteri…

5a916ac

…ng tracked nominations

replace usage of typing.List with native list

68c625c

use log.warning instead of deprecetated log.warn

3ca37a0

update name of the method that identifies untracked nominations

1c8059a

shtlrs mentioned this pull request Nov 27, 2022

Terminate nominations when members are not found #2343

Closed

add jump url to the issue's body

da3c904

shtlrs requested review from ChrisLovering and removed request for wookie184 November 27, 2022 12:29

wookie184 added t: feature New feature or request a: recruitment Related to recruitment: (talentpool) s: needs review Author is waiting for someone to review and approve labels Nov 27, 2022

Merge branch 'main' into 2226-track-old-votes-in-github

59319b4

# Conflicts: # bot/exts/recruitment/talentpool/_cog.py # bot/exts/recruitment/talentpool/_review.py

shtlrs commented Jan 1, 2023

View reviewed changes

ChrisLovering requested changes Jan 1, 2023

View reviewed changes

bot/exts/recruitment/talentpool/_cog.py Outdated Show resolved Hide resolved

bot/exts/recruitment/talentpool/_cog.py Outdated Show resolved Hide resolved

Amrou Bellalouna and others added 2 commits January 8, 2023 12:33

move Github token check to cog_load

33415da

use review start date instead of nomination inserted_at

babf906

This relies on turning the thread snowflake id into a date time We then use that for comparison, since an existing active thread id means an existing review

shtlrs requested a review from ChrisLovering January 8, 2023 11:55

wookie184 added the p: 2 - normal Normal Priority label Mar 3, 2023

shtlrs closed this Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create an admin task when votes are 2 weeks old #2323

Create an admin task when votes are 2 weeks old #2323

shtlrs commented Nov 12, 2022 •

edited

Loading

shtlrs commented Nov 12, 2022 •

edited

Loading

HassanAbouelela commented Nov 12, 2022

shtlrs commented Nov 12, 2022

shtlrs commented Nov 13, 2022 •

edited

Loading

ChrisLovering Nov 26, 2022

shtlrs Nov 26, 2022

shtlrs Nov 27, 2022

shtlrs Jan 1, 2023

ChrisLovering Nov 26, 2022

shtlrs Nov 27, 2022

shtlrs Nov 27, 2022

ChrisLovering Nov 26, 2022

shtlrs Nov 27, 2022

ChrisLovering Nov 27, 2022

ChrisLovering Nov 26, 2022

shtlrs Nov 27, 2022

ChrisLovering Nov 27, 2022

ChrisLovering Nov 26, 2022

shtlrs Nov 27, 2022

ChrisLovering Nov 27, 2022

shtlrs Nov 27, 2022

ChrisLovering commented Nov 26, 2022

shtlrs Nov 14, 2022

shtlrs Nov 26, 2022

shtlrs Nov 27, 2022

shtlrs Nov 27, 2022

shtlrs Nov 27, 2022

shtlrs Nov 27, 2022

shtlrs Jan 1, 2023

shtlrs commented Apr 20, 2023

	async def _get_forgotten_nominations(self) -> List[Nomination]:
	async def _get_forgotten_nominations(self) -> list[Nomination]:

	log.warn(f"No token for the {GithubAdminRepo.name} repository was provided, skipping issue creation.")
	log.warning(f"No token for the {GithubAdminRepo.name} repository was provided, skipping issue creation.")

Create an admin task when votes are 2 weeks old #2323

Create an admin task when votes are 2 weeks old #2323

Conversation

shtlrs commented Nov 12, 2022 • edited Loading

shtlrs commented Nov 12, 2022 • edited Loading

HassanAbouelela commented Nov 12, 2022

shtlrs commented Nov 12, 2022

shtlrs commented Nov 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChrisLovering commented Nov 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shtlrs commented Apr 20, 2023

shtlrs commented Nov 12, 2022 •

edited

Loading

shtlrs commented Nov 12, 2022 •

edited

Loading

shtlrs commented Nov 13, 2022 •

edited

Loading