Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprrove day check #223

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Imprrove day check #223

merged 2 commits into from
Jul 30, 2024

Conversation

MateoLostanlen
Copy link
Member

This new method makes it possible to sleep for 1 hour between two checks at night, so as not to use the cameras too much.

We're also fixing the static cam test that wasn't done before.

@MateoLostanlen MateoLostanlen requested a review from a team July 29, 2024 14:34
@MateoLostanlen MateoLostanlen self-assigned this Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 52.08333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (9e70b17) to head (c58c72d).

Files Patch % Lines
pyroengine/core.py 52.08% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
- Coverage    90.20%   88.84%   -1.36%     
===========================================
  Files            6        6              
  Lines          500      529      +29     
===========================================
+ Hits           451      470      +19     
- Misses          49       59      +10     
Flag Coverage Δ
unittests 88.84% <52.08%> (-1.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoLostanlen MateoLostanlen merged commit 4742146 into develop Jul 30, 2024
12 of 14 checks passed
@MateoLostanlen MateoLostanlen deleted the imprrove_day_check branch July 30, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant