Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker #207

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix docker #207

merged 2 commits into from
Jun 17, 2024

Conversation

MateoLostanlen
Copy link
Member

Quick PR:

  1. network_mode: host ensure camera to be available in the container
  2. we need to be sure to use the latest image with run

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (d8d6082) to head (2fc01d5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #207   +/-   ##
========================================
  Coverage    88.69%   88.69%           
========================================
  Files            6        6           
  Lines          398      398           
========================================
  Hits           353      353           
  Misses          45       45           
Flag Coverage Δ
unittests 88.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RonanMorgan
Copy link
Collaborator

note sure about network: host ; why do you want to do it ? which camera ?

@MateoLostanlen
Copy link
Member Author

hello @RonanMorgan on my pc the camera connected to the pc and used to capture images are not "pingable" without this line

@MateoLostanlen MateoLostanlen merged commit 97ec80c into develop Jun 17, 2024
14 checks passed
@MateoLostanlen MateoLostanlen deleted the fix_docker branch June 17, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants