-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit bbox size #166
limit bbox size #166
Conversation
Nice of you to open a PR 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I added side comments, nothing major
2bfe9eb
to
4f5f629
Compare
@frgfm some commit confusion with a test I was doing can you review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits!
Straightforward question, I assume that the predictions are listed in descending order of probability ? (so only keeping the most relevant ones) |
Yes it's sorted in nms function |
* update header (#149) * fix black (#150) * Update README.md (#151) * Promtail (#152) * Update of the main branch before the new deployment in Ardeche (#145) * ci on develop (#134) * update develop tour (#135) * fix args (#136) * fix: Fixed script arg name in src/run.py (#138) * clean backup by size (#141) * clean backup by size * black * missing deps * drop function * drop function 2 * Day only (#142) * sunset_sunrise script * update output file path * check if day time * put back real api * style * use datetime timedelta * Make all params availables from run (#144) * make all params available in run * make params availables * put back api * style * put back alert_relaxation to 2 * Yolov5 (#143) * switch to yolov5 * missing import * style * fix tests * unused import * update readme * letterbox transform * do not resize with pillow before pred * style * downgrad opencv * wrong img name * long line * missing deps * model path * header * lib for opencv * create model folder * update init * remove hub deps * update threshold * feat: Added promtail service * feat: Added promtail config file * feat: Renamed variable * feat: Renamed vars * docs: Updated setup explanation * feat: Added restart option --------- Co-authored-by: Mateo <[email protected]> * analyze stream timeout (#153) * update docker img (#154) * add utc (#155) * fix style (#158) * Ir day night (#159) * set margin to 0 * drop utc * add ir strategy * update docstring * fix style * fix missing undefinded params (#161) * Add bbox (#162) * add bbox * fix inference * style * fix vision * style vision * fix engine * keep all preds * speed up * pass dummy loc * switch to v8 * fix tests * test * drop dummy test * new api version * unsed import * install git * code quality * use bbox branch * use apt get * alert relaxation 3 * New alerte strategy (#164) * new alert system * fix unitests * Occlusion mask (#165) * add occlusion mask * trest mask * missing args * use cam_key * update test * add a test * clip values * install from main (#167) * limit bbox size (#166) * limit bbox size * style * use 4 frames (#168) * don't send bbox (#169) * prevent empty (#171) --------- Co-authored-by: fe51 <[email protected]>
Due to a recent api problem, we propose to limit the size of bboxes sent. We send a maximum of 5 boxes with 3 decimals.