Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _InverseTransform #875

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Add _InverseTransform #875

merged 2 commits into from
Jan 15, 2021

Conversation

fehiepsi
Copy link
Member

Resolves #164. It is surprisingly easy to do because we don't need to support the caching mechanism in PyTorch.

Excercised mostly with current tests.

@fehiepsi
Copy link
Member Author

@eb8680 Sorry it took a long time to address your request in pyro-ppl/funsor#386!

Copy link
Member

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see libraries converging!

@fehiepsi
Copy link
Member Author

Thanks for reviewing!

@fehiepsi fehiepsi merged commit c8e9d67 into pyro-ppl:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for InverseTransform
3 participants