Add ops.getslice for complex indexing by int,slice,None,Ellipsis #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
changed the title
7 tasks
eb8680
reviewed
Sep 26, 2021
funsor/terms.py
Outdated
| if head != slice(None): | ||
| expr = expr(**{x.var.name: head}) | ||
| if x.var.name not in expr.inputs: | ||
| return expr |
3 tasks
|
ok, I've added some simple tests for multiple value indices |
eb8680
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #556
Blocking #553
This adds
ops.getsliceto perform fancy slice operations likex[..., 0, ::2, None, :], in particular supporting nontrivial slicing, and supporting unsqueezing via None. These fancier slicing ops will be needed for symbolic Gaussians #556. Note this now distinguishes betweenops.getitemwhich supports "advanced indexing" where funsors can appear in the index, fromops.getslicewhich supports only indexing of ground values. Numpy distinguishes semantics of these two types of indexing, and it is much easier to fully implement ground indexing (which I believe this PR does forops.getitem).Tested