Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstall button and retry option #5

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Reinstall button and retry option #5

wants to merge 3 commits into from

Conversation

Rico040
Copy link

@Rico040 Rico040 commented May 10, 2024

No description provided.

Ushie
Ushie reviewed Jul 10, 2024
View reviewed changes
Copy link

@Ushie Ushie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would one want to reinstall? Retry button seems enough

@Rico040
Copy link
Author

Rico040 commented Jul 11, 2024 •
edited
Loading

Why would one want to reinstall? Retry button seems enough

After giving install permissions it just cancels installation, in my case

@Ushie
Copy link

Ushie commented Jul 11, 2024

That's covered under retry, the app should listen to the installation result and offer to retry if its anything other than success

@Rico040
Copy link
Author

Rico040 commented Jul 11, 2024

Well, that makes more sense, I'll do that in meantime

@Rico040 Rico040 marked this pull request as draft July 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ushie Ushie Ushie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rico040 @Ushie