remove spend scaling step from budget optimizer

[juanitorduz]

When looking into #1044 I encountered the following issue: The budget to allocate in the example is of the order of ~ 1e6 and I was getting an uniform split

pd.Series(mmm.optimal_allocation_dict)

Direct Mail       1.972773e+06
Insert            1.972773e+06
Newspaper         1.972773e+06
Online Display    1.972773e+06
Radio             1.972773e+06
Social Media      1.972773e+06
TV                1.972773e+06
dtype: float64

Nevertheless the plot

fig, ax = mmm.plot_budget_allocation(samples=response, figsize=(12, 8))
fig.suptitle("Response vs spent per channel");

showed

which was values of the order ~ 1e12.

I talked with @carlosagostini and notice that with the latest changes we do not need to scale the spends.

---

📚 Documentation preview 📚: https://pymc-marketing--1070.org.readthedocs.build/en/1070/

[juanitorduz]

@carlosagostini, Is this still valid, or should we remove the scaling everywhere?

[cetagostini]

Contributions still need to be scaled, but not the budget allocation, because the optimizer now returns it in original scale. So post processing is not necessary 🙌🏻

[juanitorduz]

Ok! Thanks! Si is this one good to go ?

[cetagostini]

Indeed!

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[juanitorduz]

In bc78e64 I re-ran the notebook. The results look as expected right?

[juanitorduz]

BTW: I changed the colours so that they can be synced with the user palettes (that is why we are using the "C0" and "C1") syntax

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (d05c2d8) to head (bc78e64).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
pymc_marketing/mmm/mmm.py	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   95.85%   95.88%   +0.02%     
==========================================
  Files          39       39              
  Lines        3934     3933       -1     
==========================================
  Hits         3771     3771              
+ Misses        163      162       -1     

Flag	Coverage Δ
	95.88% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cetagostini]

Everything looks good here!