automate UML diagrams #395
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 85.60% 94.35% +8.75%
==========================================
Files 22 30 +8
Lines 1716 1967 +251
==========================================
+ Hits 1469 1856 +387
+ Misses 247 111 -136 ☔ View full report in Codecov by Sentry. |
|
Where does the EDIT: Added to docs |
|
pre-commit.ci autofix |
|
Having some permission issues. Not sure what is up @drbenvincent |
.github/workflows/uml.yml
Outdated
| on: | ||
| pull_request: | ||
| branches: [main] | ||
| # paths: |
There was a problem hiding this comment.
Remove commented out code?
There was a problem hiding this comment.
Yes, at end since the files that changed wouldn't trigger this action
.github/workflows/uml.yml
Outdated
| # - "causalpy/**" | ||
| push: | ||
| branches: [main] | ||
| # paths: |
There was a problem hiding this comment.
Remove commented out code?
| with: | ||
| python-version: "3.10" | ||
|
|
||
| - name: Configure Git Identity |
There was a problem hiding this comment.
I am very much a beginner when it comes to GitHub actions, but I've not seen anything about coffin of git identity in the other workflows. Could this be related to the permissions issue?
Or is it required for the later pushed changes?
There was a problem hiding this comment.
Required for pushing later.
Could be cause of permission. Not sure at the moment
There was a problem hiding this comment.
Think it might be if repo doesn't allow for bots to push code. I am seeing that the pre-commit bot didn't push either though the command was recognized
|
@drbenvincent do you allow bots in the code base? I am noticing that the precommit auto fix didnt make a commit either |
|
Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions" |
|
Sorry for delay. Will focus on this ASAP. |
.github/workflows/uml.yml
Outdated
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Think this needs to be v4
|
Had some issues in pymc marketing |
Current settings are as below. Let me know if I need to update anything. |
Thanks for checking this @drbenvincent I was able to figure it out. Based on it coming from a fork. Waiting for passing then can add back commented code |
|
Thoughts on the options: Run only on:
In either way, it will be updated. What are your thoughts? Here is the other option: pymc-labs/pymc-marketing#967 (comment) |
Closes #178
📚 Documentation preview 📚: https://causalpy--395.org.readthedocs.build/en/395/