Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rewrites involving kronecker product #975

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

tanish1729
Copy link
Contributor

@tanish1729 tanish1729 commented Aug 17, 2024

Description

Adds the following rewrites :

  • diag(kron(a,b)) -> outer(diag(a), diag(b))
  • slogdet(kron(a,b)) -> prod(sign(a), sign(b)), sum(logdet(a), logdet(b))

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (3eea7d0) to head (329353d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/tensor/rewriting/linalg.py 69.23% 7 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
- Coverage   81.75%   81.75%   -0.01%     
==========================================
  Files         183      183              
  Lines       47753    47763      +10     
  Branches    11617    11619       +2     
==========================================
+ Hits        39042    39050       +8     
- Misses       6520     6523       +3     
+ Partials     2191     2190       -1     
Files with missing lines Coverage Δ
pytensor/tensor/rewriting/linalg.py 90.63% <69.23%> (-1.85%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo then looks good to me

pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
@jessegrabowski jessegrabowski merged commit 3e98b9f into pymc-devs:main Oct 8, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants