Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom frozendict implementation #879

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Jul 3, 2024

Description

Spin off from #842 aiming to remove the custom frozendict implementation.

Although it might be the case one day, there is currently no frozendict implementation in Python. A few libraries offer this, and we vendored one implementation (wrapper over a dict object).
We only use it in the attributes of the Elemwise object.
It might be beneficial to remove this custom object and replace it with a built-in Python immutable container (like a tuple).
However, this makes a test fail: tests_kanren:test_KanrenRelationSub_filters, more details here.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant