Remove the custom frozendict implementation #879
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spin off from #842 aiming to remove the custom frozendict implementation.
Although it might be the case one day, there is currently no frozendict implementation in Python. A few libraries offer this, and we vendored one implementation (wrapper over a dict object).
We only use it in the attributes of the
Elemwise
object.It might be beneficial to remove this custom object and replace it with a built-in Python immutable container (like a tuple).
However, this makes a test fail:
tests_kanren:test_KanrenRelationSub_filters
, more details here.Related Issue
Checklist
Type of change