-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc testing fixes #1021
base: main
Are you sure you want to change the base?
Misc testing fixes #1021
Conversation
@@ -78,7 +78,7 @@ jobs: | |||
install-jax: [0] | |||
install-torch: [0] | |||
part: | |||
- "--doctest-modules --ignore=pytensor/misc/check_duplicate_key.py pytensor --ignore=pytensor/link" | |||
- "--doctest-modules pytensor --ignore=pytensor/misc/check_duplicate_key.py --ignore=pytensor/link" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just odd to have pytensor in the middle of the ignore files
c99f711
to
8b03238
Compare
77fffef
to
f3e8575
Compare
testpaths = "tests/" | ||
[tool.pytest.ini_options] | ||
addopts = "--durations=50 --doctest-modules --ignore=pytensor/link --ignore=pytensor/misc/check_duplicate_key.py" | ||
testpaths = ["pytensor/", "tests/"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytensor is in the testpath because of --doctest-modules, so we test the code examples in the docstrings by default
f3e8575
to
5449562
Compare
5449562
to
2cab125
Compare
Only run required rewrites in JAX tests Several tests ended up not testing the JAX implementation due to constant folding of inputs.
2cab125
to
b5a0ca1
Compare
This PR does a bunch of minor cleanups on the testing suite:
📚 Documentation preview 📚: https://pytensor--1021.org.readthedocs.build/en/1021/