Skip to content

Commit

Permalink
Update OpFromGraph TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
ricardoV94 committed May 29, 2024
1 parent b322891 commit 3bd9a97
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions pytensor/compile/builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,9 @@ class OpFromGraph(Op, HasInnerGraph):
Currently does not support ``updates`` or ``givens`` argument.
.. TODO:
- examples for a multi-layer mlp. where?
- __hash__, __eq__ otherwise won't merge, try
is_same_graph_with_merge(op1.local_outputs, op2,
local_outputs)
- c_code() to remove the double overhead?
- grad() make it support DisconnectedType and the new interface
- add support for NullType and DisconnectedType when R_op supports them
- check how it works with updates.
- Allow / test merging of OpFromGraph nodes
- Add support for NullType and DisconnectedType when R_op supports them
- Add support to pickle this Op.
- Add support/test with random generator
- Add optimization to removing unused inputs/outputs
- Add optimization to work inplace on inputs when not inline
Expand Down

0 comments on commit 3bd9a97

Please sign in to comment.