Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the C4 ruff lints about comprehensions #7527

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Oct 8, 2024

Description

Enable the C4 ruff lints about comprehensions.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7527.org.readthedocs.build/en/7527/

@Armavica Armavica added maintenance pre-commit no releasenotes Skipped in automatic release notes generation labels Oct 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (4f06ab7) to head (2299083).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pymc/variational/approximations.py 83.33% 1 Missing ⚠️
pymc/variational/opvi.py 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7527   +/-   ##
=======================================
  Coverage   92.68%   92.69%           
=======================================
  Files         104      104           
  Lines       17412    17412           
=======================================
+ Hits        16139    16140    +1     
+ Misses       1273     1272    -1     
Files with missing lines Coverage Δ
pymc/backends/base.py 88.44% <100.00%> (ø)
pymc/backends/mcbackend.py 99.25% <100.00%> (ø)
pymc/backends/ndarray.py 79.09% <100.00%> (ø)
pymc/distributions/custom.py 95.54% <ø> (ø)
pymc/distributions/dist_math.py 84.17% <100.00%> (ø)
pymc/distributions/distribution.py 91.89% <100.00%> (ø)
pymc/distributions/shape_utils.py 90.90% <100.00%> (ø)
pymc/distributions/simulator.py 84.28% <ø> (ø)
pymc/distributions/timeseries.py 94.77% <100.00%> (ø)
pymc/func_utils.py 88.63% <100.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes

@Armavica Armavica merged commit 1b6d7db into pymc-devs:main Oct 8, 2024
22 checks passed
@Armavica Armavica deleted the comprehensions branch October 8, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no releasenotes Skipped in automatic release notes generation pre-commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants