Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing pytensor-devs for aesara-devs #6817

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

amyoshino
Copy link
Member

@amyoshino amyoshino commented Jul 4, 2023

What is this PR about?
Closes #6800

This PR replaces occurrences of pytensor-devs for aesara-devs in the issues hyperlinks present in docstrings. It also fix a minor typo in the "What are value variables and why are they important?" section of the "PyMC and PyTensor" notebook.

What it is replacing?
pytensor-devs/pytensor -> aesara-devs/aesara
pytensor-devs/aeppl -> aesara-devs/aeppl

Tests:

  • Hyperlinks are working
  • grep -r "pytensor-devs" returns no records

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

📚 Documentation preview 📚: https://pymc--6817.org.readthedocs.build/en/6817/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #6817 (4381235) into main (f67ff8b) will decrease coverage by 46.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6817       +/-   ##
===========================================
- Coverage   92.02%   45.95%   -46.08%     
===========================================
  Files          95       95               
  Lines       16261    16261               
===========================================
- Hits        14964     7472     -7492     
- Misses       1297     8789     +7492     
Impacted Files Coverage Δ
pymc/distributions/shape_utils.py 48.48% <ø> (-46.47%) ⬇️
pymc/logprob/rewriting.py 63.48% <ø> (-26.41%) ⬇️
pymc/sampling/jax.py 98.26% <ø> (ø)

... and 74 files with indirect coverage changes

@amyoshino amyoshino marked this pull request as ready for review July 4, 2023 20:02
Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amyoshino for opening your PR :) One minor edit and we should be good to merge!

docs/source/learn/core_notebooks/pymc_pytensor.ipynb Outdated Show resolved Hide resolved
Change pytensor hypterlink to "pymc-devs/pytensor"

Co-authored-by: larryshamalama <[email protected]>
@amyoshino
Copy link
Member Author

amyoshino commented Jul 5, 2023

Amazing, thanks for the review @larryshamalama! I just accepted your suggestion, let me know if something else is missing :)

Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution! :)

@larryshamalama larryshamalama merged commit 659f177 into pymc-devs:main Jul 6, 2023
20 of 21 checks passed
@amyoshino amyoshino deleted the pytensor_devs branch July 6, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Address occurrences of pytensor-devs
2 participants