Allow non-scalar measurable switch mixtures #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
make_switch_mixtures_more_flexible_basic
branch
from
008e3b0
to
2441185
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6796 +/- ##
==========================================
- Coverage 91.92% 88.22% -3.71%
==========================================
Files 95 95
Lines 16197 16233 +36
==========================================
- Hits 14889 14321 -568
- Misses 1308 1912 +604
|
There was a problem hiding this comment.
As always, looks great @ricardoV94 😅 As usual, some questions from my side
|
|
||
| invalid_mix = pt.switch(valid_switch_cond, valid_true_branch, invalid_false_branch) | ||
| fgraph, _, _ = construct_ir_fgraph({invalid_mix: invalid_mix.type()}) | ||
| assert not isinstance(fgraph.outputs[0].owner.op, MeasurableVariable) |
There was a problem hiding this comment.
Would it be more clear to rename the fgraphs and invalid_mixes in this test?
There was a problem hiding this comment.
On a second thought... rename to what? I feel the names are pretty reasonable?
There was a problem hiding this comment.
Ah, I was just alluding to the redundancy in names (three presences of fgraph, two of invalid_mix).
ricardoV94
force-pushed
the
make_switch_mixtures_more_flexible_basic
branch
from
2441185
to
9f65891
Compare
larryshamalama
approved these changes
Jun 29, 2023
|
|
||
| invalid_mix = pt.switch(valid_switch_cond, valid_true_branch, invalid_false_branch) | ||
| fgraph, _, _ = construct_ir_fgraph({invalid_mix: invalid_mix.type()}) | ||
| assert not isinstance(fgraph.outputs[0].owner.op, MeasurableVariable) |
There was a problem hiding this comment.
Ah, I was just alluding to the redundancy in names (three presences of fgraph, two of invalid_mix).
ricardoV94
commented
Jun 30, 2023
ricardoV94
force-pushed
the
make_switch_mixtures_more_flexible_basic
branch
from
9f65891
to
df9f1b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the supported Mixture graphs beyond the scalar case.
It comes at the cost of not creating a lazy evaluation logp graph that the old MixtureRV approach did, but benefits from allowing arbitrary measurable variables and not just pure RVs.
In a future PR I intend to introduce a lazy Mixture RV that brings back that functionality, but that's right now blocked by pymc-devs/pytensor#329
CC @shreyas3156
📚 Documentation preview 📚: https://pymc--6796.org.readthedocs.build/en/6796/