Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set notebook cell timeout to 2 minutes #61

Merged
merged 3 commits into from
Aug 19, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 19, 2023

To allow for long running processes that require actual computation extend the notebook cell timeout from the default 30 seconds to 120 seconds (2 minutes).

* To allow for long running processes that require actual computation
  extend the notebook cell timeout from the default 30 seconds to 120
  seconds (2 minutes).
   - c.f. https://jupyterbook.org/en/stable/customize/config.html

* To allow for long running processes that require actual computation
  extend the notebook cell timeout from the default 30 seconds to 500
  seconds (which is 5 minutes).
   - c.f. https://jupyterbook.org/en/stable/customize/config.html
@matthewfeickert
Copy link
Member Author

It seems like this really hangs on InterpolationCodes.ipynb for some reason.

@matthewfeickert
Copy link
Member Author

reading sources... [ 64%] Toys                                                 
/__w/pyhf-tutorial/pyhf-tutorial/book/Toys.ipynb: Executing notebook using local CWD [mystnb]
/__w/pyhf-tutorial/pyhf-tutorial/book/Toys.ipynb: Executed notebook in 80.70 seconds [mystnb]
reading sources... [ 71%] UpperLimitsTable                                     
/__w/pyhf-tutorial/pyhf-tutorial/book/UpperLimitsTable.ipynb: Executing notebook using local CWD [mystnb]
/__w/pyhf-tutorial/pyhf-tutorial/book/UpperLimitsTable.ipynb: Executed notebook in 80.10 seconds [mystnb]

We could probably drop this to 120 seconds to be safe. Though looks like we're having some issues with the Toys notebook actually converging.

@matthewfeickert matthewfeickert changed the title fix: Set notebook cell timeout to 5 minutes fix: Set notebook cell timeout to 2 minutes Aug 19, 2023
@matthewfeickert
Copy link
Member Author

This extends the time it takes for the CI to run, but I think it is worth if for the time being. We should investigate why the notebooks with IPython widgets take so long to run though

reading sources... [ 21%] InterpolationCodes                                   
/__w/pyhf-tutorial/pyhf-tutorial/book/InterpolationCodes.ipynb: Executing notebook using local CWD [mystnb]
/__w/pyhf-tutorial/pyhf-tutorial/book/InterpolationCodes.ipynb: Executed notebook in 122.74 seconds [mystnb]
reading sources... [ 35%] Modifiers                                            
/__w/pyhf-tutorial/pyhf-tutorial/book/Modifiers.ipynb: Executing notebook using local CWD [mystnb]
/__w/pyhf-tutorial/pyhf-tutorial/book/Modifiers.ipynb: Executed notebook in 122.13 seconds [mystnb]

@matthewfeickert matthewfeickert merged commit d45792c into main Aug 19, 2023
4 checks passed
@matthewfeickert matthewfeickert deleted the fix/extend-execution-timeout branch August 19, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant