Make depth_stencil_attachment follow the spec #611
+149
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyellin
commented
Oct 3, 2024
| depth_keys_okay = True | ||
| depth_load_op = ds_attachment["depth_load_op"] | ||
| depth_store_op = ds_attachment["depth_store_op"] | ||
| if depth_load_op == "clear": |
There was a problem hiding this comment.
Is there a better way of doing this? Will anyone specify "clear" by its integer value?
There was a problem hiding this comment.
This is fine, the integer values of enums from wgpu-native are an implementation detail and should not be usable by the caller.
almarklein
reviewed
Oct 3, 2024
| depth_keys_okay = True | ||
| depth_load_op = ds_attachment["depth_load_op"] | ||
| depth_store_op = ds_attachment["depth_store_op"] | ||
| if depth_load_op == "clear": |
There was a problem hiding this comment.
This is fine, the integer values of enums from wgpu-native are an implementation detail and should not be usable by the caller.
wgpu/backends/wgpu_native/_api.py
Outdated
Comment on lines
2766
to
2770
| warnings.warn( | ||
| f"Unexpected key {key} in depth_stencil_attachment", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
We use logger.warning() instead of the warnings module.
Another thing is that (I think) this warning would be shown on each draw, which may be a bit much. Perhaps we can do something like:
if not getattr(self._device, "_showed_depth_stencilwarning", False):
self._device._showed_depth_stencilwarning = True
logger.warning(....)Simplify test_wgpu_native_render.py Add test that warnings occur, but only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/webgpu/#depth-stencil-attachments
Make depth_stencil_attachment more closely follow the specification. No longer do we need to specify stencil_xxx if it's a depth, and no need to specify depth_xxx if it's a stencil. We only need to specify "color" if it's a "clear".