Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In benchmarking for pygfx/pygfx#763 it looked like the
proxy_func
is called a lot, so I figured that of it could be optimized it would be an easy win. It looks like the result is not really measurable, but nevertheless might be worth applying.deque
instead of a list.ErrorHandler
class, so that the logic in theproxy_func
becomes simpler. Also cleaner code imo.error_handler
object and no longer usesself
.