Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Shadertoy Utility #401

Merged
merged 10 commits into from
Nov 6, 2023
Merged

Conversation

Vipitis
Copy link
Contributor

@Vipitis Vipitis commented Oct 28, 2023

picking up from #360

Several steps to this PR (will be updated)

I welcome any feedback to my additions. I don't want to break any existing functionality.

wgpu/utils/shadertoy.py Outdated Show resolved Hide resolved
@Vipitis
Copy link
Contributor Author

Vipitis commented Nov 5, 2023

short update, I had encountered more panics and found a ways to catch them by doing more translations.
And now that glsl errors get handled properly, it really shouldn't be here anymore.

Would it be okay to take all of that validation out (I will keep it in own project instead) and just add the offscreen and snapshot features with this PR for now?

wgpu/utils/shadertoy.py Outdated Show resolved Hide resolved
@almarklein
Copy link
Member

Would it be okay to take all of that validation out (I will keep it in own project instead) and just add the offscreen and snapshot features with this PR for now?

Yes, that sounds good! The glsl validation are present in the latest wgpu-native release, so they will be in wgpu-py in the next update.

@Vipitis Vipitis marked this pull request as ready for review November 6, 2023 15:50
@Vipitis Vipitis requested a review from Korijn as a code owner November 6, 2023 15:50
@Korijn Korijn merged commit dbb991d into pygfx:main Nov 6, 2023
18 checks passed
@almarklein
Copy link
Member

Thanks!

@Vipitis Vipitis deleted the shadertoy-improvements branch November 14, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants