Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in Window docs #3194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gavinmorrow
Copy link

No description provided.

@gavinmorrow gavinmorrow requested a review from a team as a code owner October 26, 2024 13:38
@gavinmorrow gavinmorrow changed the title Fix grammar in window.rst Fix grammar in Window docs Oct 26, 2024
@@ -61,8 +61,8 @@
Event behavior if multiple Windows are created: When the close button is
pressed, a ``WINDOWCLOSE`` event is sent. You need to explicitly destroy
the window. Note that the event ``QUIT`` will only be sent if all Window
has been destroyed.
the window. Note that the event ``QUIT`` will only be sent if all Windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's plurial, then it should not be capitalized as well.

Copy link
Member

@oddbookworm oddbookworm Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually suggest doing something like this instead

``Window``s

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to follow the example of the rest of the file, where Window is capitalized (including plurals). In the Surface docs, the same convention is followed.

@damusss damusss added the docs label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants