Fixes for rwobject (now iostream) SDL3 #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 failing check due to numpy.alltrue being removed in numpy 2.0. |
Starbuck5
force-pushed
the
rwobject-fixes-sdl3
branch
from
6e70144
to
6ab3edf
Compare
Merged
MyreMylar
approved these changes
Sep 29, 2024
|
This PR was made a while back, has there been any SDL3 changes in the meantime that makes this PR need changes? |
Starbuck5
force-pushed
the
rwobject-fixes-sdl3
branch
from
ec1bae0
to
f5cffaf
Compare
Starbuck5
force-pushed
the
rwobject-fixes-sdl3
branch
from
0fc7fd5
to
7244df0
Compare
Starbuck5
force-pushed
the
rwobject-fixes-sdl3
branch
from
22fb3b5
to
7202d48
Compare
To compile: no I've updated it now and it should be good. I'm aware the rwobject.c changes probably look scary: all my changes have been for the SDL3 code paths, SDL2 is unaffected by these changes. |
ankith26
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SDL3, the RWops system has been remade into the IOStream system.
So, for SDL itself they have an oldnames compatibility layer that I've enabled at compile time for my SDL3 experimentation. This means our code can still say "SDL_RWops*" and other "RW" things. But they don't have this for the satellite libraries (yet?), so I've gone ahead and implemented explicit preprocessor macros to switch the "RW" load functions to the "IO" load functions.
The system has also changed how custom RWops are created, and the signature of the callbacks, so this patch fixes that to work in both SDL2 and SDL3. It's one of the more complex patches I've submitted for SDL3 support, but the big idea of it is that it doesn't change anything in SDL2, to stay safe.