drop the length from numpy
's fixed-width string dtypes
#9586
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting arrays of fixed-width string / bytes dtypes to their base dtype (
np.str_
andnp.bytes_
) innp.result_type
, we can avoid accidentally truncating the replacement strings inxr.where
.While this works, I wonder if we instead should ask
numpy
to do this for us? I.e.np.result_dtype(np.dtype("<U1"), str)
should returnnp.str_
, notnp.dtype("<U1")
.<U
dtypes #9180whats-new.rst