Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zarr ArrayWriter customizable when writing dataset to zarr #9471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AchilleAsh
Copy link

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

The dump_to_store function was already exposing the ability to specify a writer, but this was never exposed on any of the to_zarr function, and was simply hardcoded to ArrayWriter.

This PR adds the optional keyword argument to override it, and just pass it to the dump function.

Let me know if you need me to add documentation on it.

Thanks!

Copy link

welcome bot commented Sep 9, 2024

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@shoyer
Copy link
Member

shoyer commented Sep 10, 2024

Hi @AchilleAsh, what use cases did you have in mind here? ArrayWriter was not intended to be a public API.

@TomNicholas TomNicholas added topic-backends topic-zarr Related to zarr storage library labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-backends topic-zarr Related to zarr storage library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants