Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure group names are preserved on update. #9309

Closed
wants to merge 2 commits into from
Closed

Ensure group names are preserved on update. #9309

wants to merge 2 commits into from

Conversation

flamingbear
Copy link
Contributor

@flamingbear
Copy link
Contributor Author

Closing because #9297 will be done soon.

@flamingbear flamingbear closed this Aug 2, 2024
@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Aug 27, 2024
@TomNicholas TomNicholas reopened this Aug 27, 2024
@TomNicholas
Copy link
Member

This fixes the problem and adds a regression test, so I think we should just merge this too.

@TomNicholas TomNicholas enabled auto-merge (squash) August 27, 2024 16:01
@TomNicholas TomNicholas mentioned this pull request Aug 27, 2024
Open
27 tasks
@TomNicholas
Copy link
Member

Wait this is now a zero-line PR?!? Guess we don't need it anymore then haha

@flamingbear
Copy link
Contributor Author

Wait this is now a zero-line PR?!? Guess we don't need it anymore then haha

Yup, looks like @eni-awowale added these changes too. 🙃

@flamingbear
Copy link
Contributor Author

Unless you want to merge no changes to close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTree.update can cause multiple root groups.
2 participants
@flamingbear @TomNicholas