Add typing to test_plot.py #8889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Illviljan
commented
Mar 29, 2024
| # nb. this function also matches meshes from pcolormesh | ||
| return plt.gcf().findobj(mpl.collections.QuadMesh) | ||
| return plt.gcf().findobj(mpl.collections.QuadMesh) # type: ignore[return-value] # mpl error? |
There was a problem hiding this comment.
I believe the typing for findobj is wrong. Looks to me it mostly returns the same type as the input.
https://github.com/matplotlib/matplotlib/blob/78b6bdc04f89dafe4d157855a9023826cab8a0fd/lib/matplotlib/artist.pyi#L131-L135
Probably should be something like TypeVar("T_Artist", bound=Artist).
There was a problem hiding this comment.
cc @ksunden if you're still interested.
There was a problem hiding this comment.
There was a problem hiding this comment.
Nice, thank you @ksunden !
Illviljan
commented
Mar 29, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce typing on all tests in
test_plot.pyand add the remaining type hints.