use vectorcall calling convention for performance #792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Uses Python's "vectorcall" calling convention instead of
PyAny::call1
to avoid creating intermediate tuples. Only works on supported Python versions. (3.9+, I think, let's confirm with CI.)In the long term I'd like to add a feature to upstream PyO3 which does this and also supports keyword arguments. Seems like we don't generally use keyword arguments so not relevant to us here. Probably also with a more generic interface than just a slice-of-any as input.
Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)