-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run pydantic tests as an allowed-to-fail job #767
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 99 99
Lines 14290 14290
Branches 25 25
=======================================
Hits 13386 13386
Misses 898 898
Partials 6 6 Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #767 will improve performances by 10.98%Comparing Summary
Benchmarks breakdown
|
bcf723f
to
27fc28b
Compare
please review |
ec931f5
to
dadb6e7
Compare
Will this cause CI to fail if there are breaking changes? I think we frequently do have breaking changes in pydantic-core in things that "aren't public", just trying to understand if this is just meant to tell us if there is a problem or if it is meant to prevent merging the changes. In the second case, I think it will add some unnecessary hassle |
I've pushed a commit which deliberately fails the integration tests in order to show that CI should still overall be green (i.e. this will be a canary rather than a blocker). |
When I have approval, I will drop the second commit before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I think you might also need to add allowed-failures
to alls-green check.
d5dd4f3
to
71bf4a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
71bf4a8
to
38887b4
Compare
Change Summary
Runs pydantic tests in this CI, which help should catch incompatibilities and breaking changes before they make it downstream.
Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @dmontagu