run pydantic tests as an allowed-to-fail job

[davidhewitt]

Change Summary

Runs pydantic tests in this CI, which help should catch incompatibilities and breaking changes before they make it downstream.

Related issue number

N/A

Checklist

• Unit tests for the changes exist
• Documentation reflects the changes where applicable
• Pydantic tests pass with this pydantic-core (except for expected changes)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

[codecov]

Codecov Report

Merging #767 (71bf4a8) into main (e3ceb4b) will not change coverage.
The diff coverage is n/a.

❗ Current head 71bf4a8 differs from pull request most recent head 38887b4. Consider uploading reports for the commit 38887b4 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          99       99           
  Lines       14290    14290           
  Branches       25       25           
=======================================
  Hits        13386    13386           
  Misses        898      898           
  Partials        6        6           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ceb4b...38887b4. Read the comment docs.

[codspeed-hq]

CodSpeed Performance Report

Merging #767 will improve performances by 10.98%

_{Comparing dh/pydantic-integration (38887b4) with main (1382deb)}

Summary

🔥 1 improvements
✅ 125 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	dh/pydantic-integration	Change
🔥	test_tagged_union_int_keys_json	48.2 µs	43.5 µs	+10.98%

[davidhewitt]

please review

[dmontagu]

Will this cause CI to fail if there are breaking changes? I think we frequently do have breaking changes in pydantic-core in things that "aren't public", just trying to understand if this is just meant to tell us if there is a problem or if it is meant to prevent merging the changes. In the second case, I think it will add some unnecessary hassle

[davidhewitt]

I've pushed a commit which deliberately fails the integration tests in order to show that CI should still overall be green (i.e. this will be a canary rather than a blocker).

[davidhewitt]

When I have approval, I will drop the second commit before merge.

[samuelcolvin]

looks good, I think you might also need to add allowed-failures to alls-green check.

[davidhewitt]

Done, see e.g. https://github.com/pydantic/pydantic-core/actions/runs/5574940643/jobs/10184312544?pr=767

[dmontagu]

lgtm