fix borrow error when serializing recursive models #764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes a borrow error when serializing a recursive model.
The cause was because we took a
&mut
borrow on theSchemaSerializer
into_json
but then attempt to clone (!!) it when we fetch__pydantic_serializer__
.I've changed to (a) not take a
&mut borrow
and (b) not clone when fetching__pydantic_serializer__
.Related issue number
pydantic/pydantic#6571
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @samuelcolvin