-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose wrapped iterator in SerializationIterator #1399
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 90.21% 89.54% -0.68%
==========================================
Files 106 109 +3
Lines 16339 17348 +1009
Branches 36 41 +5
==========================================
+ Hits 14740 15534 +794
- Misses 1592 1794 +202
- Partials 7 20 +13
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test failure looks unrelated. |
CodSpeed Performance ReportMerging #1399 will not alter performanceComparing Summary
|
981b961
to
6e3ed61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's get a final review by either @davidhewitt or @samuelcolvin.
Thanks for your patience with this review process!
Change Summary
We're currently working around pydantic#8907 by parsing the pointer out of the
repr()
. To make this workaround slightly better, we'd like to expose the wrapped iterator inSerializationIterator
via.iterator
.Related issue number
SerializationIterator
pydantic#8907Checklist
pydantic-core
(except for expected changes)