-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeSource.work_dir
#532
base: main
Are you sure you want to change the base?
Conversation
Deploying logfire-docs with Cloudflare Pages
|
Can we dogfood with the resource attribute first? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 132 132
Lines 10056 10060 +4
Branches 1360 1360
=========================================
+ Hits 10056 10060 +4 ☔ View full report in Codecov by Sentry. |
Example: | ||
If the `code.filename` is `/path/to/project/src/logfire/main.py` and the `root_path` is `src/`, the URL | ||
for the source code will be `src/path/to/project/src/logfire/main.py`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs updating
"""The root path for the source code in the repository. | ||
|
||
Example: | ||
If the `code.filename` is `/path/to/project/src/logfire/main.py` and the `root_path` is `src/`, the URL | ||
for the source code will be `src/path/to/project/src/logfire/main.py`. | ||
""" | ||
|
||
work_dir: str = field(default='.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this setting at all? Isn't it just os.getcwd()
?
Should I add the "exclude" already here?