Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain coordinates should be real #156

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Domain coordinates should be real #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40981cd
domain coordinates must be real
e-moral-sanchez Jun 14, 2024
9766ef4
Merge branch 'master' into real_coord
campospinto Jul 11, 2024
56f13eb
coordinates tests must be real
e-moral-sanchez Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sympde/topology/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,7 +750,7 @@ def __new__(cls, name, dim, min_coords, max_coords):
raise ValueError("Min coordinates must be smaller than max")

coord_names = 'x1:{}'.format(dim + 1)
coordinates = symbols(coord_names)
coordinates = symbols(coord_names, real=True)

# Choose which type to use:
# a) if dim <= 3, use Line, Square or Cube;
Expand Down
2 changes: 1 addition & 1 deletion sympde/topology/tests/test_gallery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from sympy import Tuple
from sympy import symbols

x1, x2, x3 = symbols('x1, x2, x3')
x1, x2, x3 = symbols('x1, x2, x3', real=True)

from sympde.topology import Interval, ProductDomain, InteriorDomain, Domain
from sympde.topology import Line, Square, Cube, NCubeInterior
Expand Down