[JOSS] Reproducibility - Resolve issue with looking for benchmark tests in the wrong path. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aholmes
force-pushed
the
aholmes-update-benchmark-test-path
branch
2 times, most recently
from
08144e8
to
8c9c477
Compare
In pyccel#5, benchmarks were moved to the tests/ directory from the benchmark_code/ directory. This change updates that path. This error is received on attempting to run the benchmarks: ```sh $ python benchmarks/run_benchmarks.py --verbose =========================================== Ackermann =========================================== Traceback (most recent call last): File "/home/aholmes/repos/pyccel-benchmarks/benchmarks/run_benchmarks.py", line 209, in <module> shutil.copyfile(test_file, os.path.join(new_folder, basename)) File "/usr/lib/python3.10/shutil.py", line 254, in copyfile with open(src, 'rb') as fsrc: FileNotFoundError: [Errno 2] No such file or directory: '/home/aholmes/repos/pyccel-benchmarks/benchmarks/benchmark_code/ackermann_mod.py' ``` Related: openjournals/joss-reviews#4991
aholmes
force-pushed
the
aholmes-update-benchmark-test-path
branch
from
7b5e223
to
3adea34
Compare
|
Sorry for the PR spam. I made a mistake in my commit message and had to rebase. This PR may end up being unable to merge due to the force push. I'll fix it up if that happens. |
|
@EmilyBourne I just noticed another reference to the "benchmark_code/" directory in README.md. There may be other locations worth checking for. Thanks! |
Yes, I was just fixing that when I saw your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5, benchmarks were moved to the tests/ directory from the benchmark_code/ directory. This change updates that path.
This error is received on attempting to run the benchmarks:
$ python benchmarks/run_benchmarks.py --verbose =========================================== Ackermann =========================================== Traceback (most recent call last): File "/home/aholmes/repos/pyccel-benchmarks/benchmarks/run_benchmarks.py", line 209, in <module> shutil.copyfile(test_file, os.path.join(new_folder, basename)) File "/usr/lib/python3.10/shutil.py", line 254, in copyfile with open(src, 'rb') as fsrc: FileNotFoundError: [Errno 2] No such file or directory: '/home/aholmes/repos/pyccel-benchmarks/benchmarks/benchmark_code/ackermann_mod.py'Related openjournals/joss-reviews#4991