Non Matching Multipatch #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikSchnack
force-pushed
the
non_matching_multipatch
branch
from
a358429
to
bbad569
Compare
FrederikSchnack
force-pushed
the
non_matching_multipatch
branch
from
1a24664
to
c810edc
Compare
FrederikSchnack
force-pushed
the
non_matching_multipatch
branch
from
c810edc
to
7fbaecf
Compare
yguclu
added
bug
yguclu
changed the title
yguclu
approved these changes
Aug 1, 2024
yguclu
added a commit
that referenced
this pull request
Aug 5, 2024
Provide a `MatrixFreeLinearOperator` class which is a subclass of the abstract class `LinearOperator`. The new class allows creating a general matrix-free linear operator. The constructor only requires the domain, codomain and a callable `dot` method. Notes: - The provided `dot` method may or may not take an `out` argument. - A `transpose_dot` method may also be provided (mandatory to instantiate the `transpose()` linear operator). - Unit tests have been added. Additional changes: - We stop passing the deprecated `tol` argument in calls to SciPy's minres and we use `rtol` instead, which requires SciPy >= 1.12. This fixes #419. - We stop supporting Python 3.8 because of SciPy 1.12. Python 3.8 is close to end-of-life anyway, see https://devguide.python.org/versions. - We also verify the initial convergence in the minres linear solver to avoid iterating when the initial solution is good enough (which may cause a division-by-zero error). - We also revert the changes to files *psydac/api/settings.py* and *pyproject.toml* which were erroneously made in PR #320 --------- Co-authored-by: e-moral-sanchez <[email protected]> Co-authored-by: Martin Campos Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR is ready for reviews now. I think it's best to discuss most of the open questions below when working on the unification of the single-patch - multi-patch interface. And maybe create a more sustained and documented example gallery.
List of changes
__init__.pyto testsTO DO (future work)
Work for other PRs
maxwell_sscbranch at least for matching domainsfeec/multipatch(/examples)folderOpen questions:
Notes:
psydac/psydac/api/fem.py
Line 793 in e84552a