Skip to content

Commit

Permalink
poetry: change minimum Python version to 3.10
Browse files Browse the repository at this point in the history
We are using some features only available in Python 3.10, so we need
to set this as the minimum version.
  • Loading branch information
dlech committed Jul 1, 2024
1 parent 91d7226 commit 21be7c3
Show file tree
Hide file tree
Showing 6 changed files with 64 additions and 163 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
python-version: [ '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '3.10', '3.11', '3.12' ]
steps:
- run: pipx install poetry
- uses: actions/setup-python@v4
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed
- Improved `SyntaxError` handling in `lwp3 repl` command.
- Minimum Python version changed to 3.10.

### Fixed
- Fixed `PortID` exception when running `lwp3 repl` command.
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ choice to run the following:

git clone https://github.com/pybricks/pybricksdev
cd pybricksdev
poetry env use python3.8
poetry env use python3.12
poetry install
code .

On Windows, you may need to use the full path to `python3.8` (run `py -0p` to find it).
On Windows, you may need to use the full path to `python3.12` (run `py -0p` to find it).

You will need to tell VS Code to use `.venv` as the Python interpreter. It
should ask you about this the first time you open the project folder.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ operations from within a Python script.

### Python Runtime

`pybricksdev` requires Python 3.8 or higher.
`pybricksdev` requires Python 3.10 or higher.

- For Windows, use the [official Python installer][py-dl] or the [Windows Store][py38-win].
- For Mac, use the [official Python installer][py-dl] or Homebrew (`brew install python@3.8`).
- For Linux, use the distro provided `python3.8` or if not available, use a Python
- For Mac, use the [official Python installer][py-dl] or Homebrew (`brew install python@3.12`).
- For Linux, use the distro provided `python3.12` or if not available, use a Python
runtime version manager such as [asdf][asdf] or [pyenv][pyenv].


Expand Down Expand Up @@ -79,7 +79,7 @@ following:
To install `pybricksdev` as a library, we highly recommend using a virtual
environment for your project. Our tool of choice for this is [poetry]:

poetry env use python3.8
poetry env use python3.12
poetry add pybricksdev

Of course you can always use `pip` as well:
Expand Down
Loading

0 comments on commit 21be7c3

Please sign in to comment.