update Plugin and Action in plugin.py #388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. convert context and instance from argument to class attribute 2. append repair and other customize method into Plugin.actions
This reverts commit 24ff0ca.
1. add context and instance as Plugin attr so user no need to care about arguments while developing plugin 2. add context and instance to Actions, so action can communicate with rest data 3. append repair and other custom action into Plug.actions while Plugins are created.
|
Thanks for this @kosam0913, welcome to Pyblish. :) The most important aspect of developing for Pyblish is to maintain backwards compatibility, so have a look at what AppVeyor is complaining about first of all. Second would you be able to provide some examples of what your changes would mean? Some usage examples, along with some of the problem this addition solves. What problem should a developer be having to benefit from this change? |
modify for compatibility of python<3.5
add back Plugin.repair for test_plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal： to let developing pyblish plugin be more developer friendly (sort of)
Motivation: same as above~
Modifications：