Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter/Google Colab quickstart example for pypdf_table_extraction (Camelot) #31

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

alexfazio
Copy link

Hello,

I am following up regarding #503.

Been working with Camelot in Google Colab and have created a quickstart-style example that I believe would be a valuable addition to the project's repository and documentation.

The example notebook demonstrates how to set up and use Camelot within the Google Colab environment, making it easier for users to get started with the library. It includes step-by-step instructions, code snippets, and explanations to guide users through the process.

I have attached the example notebook to this pull request. Please review it and consider including it in the project's documentation or examples section.

Thank you for your consideration. If you have any questions or suggestions for improvement, please let me know.

Best regards,

@bosd
Copy link
Collaborator

bosd commented Aug 6, 2024

Thanks for opening this PR.
Can you please update it to point to this new repo / package name?

@stefan6419846
Copy link

To add on this: Could you please rename "PyPDF2" to "pypdf" as well? It seems like you are already pointing to the correct repository, but the "PyPDF2" package name is not maintained any more.

@bosd bosd changed the title Add Jupyter/Google Colab quickstart example for Camelot Add Jupyter/Google Colab quickstart example for pypdf_table_extraction (Camelot) Aug 9, 2024
@bosd bosd added enhancement New feature or request good first issue Good for newcomers labels Aug 10, 2024
@alexfazio
Copy link
Author

To add on this: Could you please rename "PyPDF2" to "pypdf" as well? It seems like you are already pointing to the correct repository, but the "PyPDF2" package name is not maintained any more.

Hello,

I have updated the Colab notebook to reflect the requested changes, including renaming "PyPDF2" to "pypdf" and updating the dependencies accordingly. I have also tested everything to ensure it is functioning correctly.

You can review the latest commit here: Latest Commit.

Please let me know if there's anything else needed before merging.

Copy link
Collaborator

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work!! Much appreciated.

Code review & quick functional test.
Looks good to me.
Some minor suggestions made about the package name and references.

Please rename the file to pypdf_table_extraction_quick_start_notebook.ipynb

examples/camelot_quick_start_notebook.ipynb Show resolved Hide resolved
examples/camelot_quick_start_notebook.ipynb Outdated Show resolved Hide resolved
examples/camelot_quick_start_notebook.ipynb Show resolved Hide resolved
examples/camelot_quick_start_notebook.ipynb Outdated Show resolved Hide resolved
examples/camelot_quick_start_notebook.ipynb Outdated Show resolved Hide resolved
examples/camelot_quick_start_notebook.ipynb Show resolved Hide resolved
examples/camelot_quick_start_notebook.ipynb Show resolved Hide resolved
@bosd
Copy link
Collaborator

bosd commented Aug 14, 2024

One addition.. small suggestion, non blocking.
Maybe it is possible to output to a df as in this example.
https://gist.github.com/vinayak-mehta/e5949f7c2410a0e12f25d3682dc9e873
As it provides a direct feedback. It is a but more user friendly, then having to browse to the outputs folder to see the result.

@alexfazio
Copy link
Author

Thanks for all your work!! Much appreciated.

Code review & quick functional test. Looks good to me. Some minor suggestions made about the package name and references.

Please rename the file to pypdf_table_extraction_quick_start_notebook.ipynb

I have implemented all your feedback except for the link to the main repository for the Colab button.

Please double-check and let me know if you have any further comments.

@bosd
Copy link
Collaborator

bosd commented Aug 15, 2024

@alexfazio Thanks for your prompt follow up.
Please check your commits. As the latest one seems to introduce some noise, as it also includes the output from the terminal.
Some of them are undo-ing the changes like the rename.

@bosd
Copy link
Collaborator

bosd commented Aug 15, 2024

Good catch, let's add .DS_Store as well 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants