-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect camelot in pypdf_table_extraction namespace #11
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Maybe put line end at test_rename.py 😉
c1d3630
to
ca1dd07
Compare
@MartinThoma can I have your opinion here? |
@@ -55,6 +56,7 @@ myst-parser = {version = ">=0.16.1"} | |||
|
|||
[tool.poetry.scripts] | |||
camelot = "camelot.__main__:main" | |||
table_extraction = "pypdf_table_extraction.__main__:main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably better to do pdf_table_extraction
or pypdf_table_extraction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we go with pypdf_table_extraction
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK using pypdf_table_extraction
would allow to use the same name for both calling the script directly and calling the module through python -m pypdf_table_extraction
, which would avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, calling the script with the same name as for the module is the way to go
There is already another module named pdf_table_extraction so using that name would also lead to confusion.
Is it ok, to move forward with this one and merge? |
On a second thought, Let's merge this, after we merged all the open PR's from the old repo's here. |
This is the elaboration of #9 and the first step in rebranding.
I copied the file structure to
/pypdf_table_extraction
and imported all the objects fromcamelot
where needed. This way I tried to achieve to be completely backwards compatible.