Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global set ember alerts to closeAfter infinite in tests #512

Closed
lkleisa opened this issue Mar 6, 2023 · 1 comment
Closed

Global set ember alerts to closeAfter infinite in tests #512

lkleisa opened this issue Mar 6, 2023 · 1 comment
Labels
Irrelevant without EmberJS Nice to have Would be nice to have but not a priority plan needs to be planned

Comments

@lkleisa
Copy link
Collaborator

lkleisa commented Mar 6, 2023

In #497, we wrote a test, that checks if the backend sends an alert for not valid model in create. For no reason, ember displays alerts only one milisec and because of that, the assertion for the text in the alert is always false. Because of that, we've set the closeAfter for the error alert in the person-new.js file to infinite (closeAfter: null makes this). This is done here: https://github.com/puzzle/skills/blob/feature/497-email-regex/frontend/app/components/person-new.js#L103.
It would be nice, if we can set the closeAfter for tests to null globally, becauase we want to test this maybe at another location. Here is an example from someone: adopted-ember-addons/ember-notify#88 (comment)

@Robin481 Robin481 added plan needs to be planned Nice to have Would be nice to have but not a priority labels Mar 7, 2023
@Robin481
Copy link
Member

Robin481 commented Apr 4, 2024

Irrelevant because of frontend removal

@Robin481 Robin481 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Irrelevant without EmberJS Nice to have Would be nice to have but not a priority plan needs to be planned
Projects
None yet
Development

No branches or pull requests

2 participants