rename package to `spago-legacy` to help NixPkgs #3

peterbecich · 2024-07-06T02:00:45Z

Description of the change

This package is currently spago in NixPkgs:
https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=spago

The Nix configuration for that is generated from this Cabal file. Renaming to spago-legacy will help clear the path for NixPkgs update to the new Spago.

I think it's unnecessary for the spago binary to be renamed to spago-legacy.

If this PR is merged, NixPkgs will be updated to the latest commit in this repo spago-legacy.

cabal build --enable-tests

succeeds with GHC 9.2

stack build succeeds.

Please merge this PR and make a fix version/release 0.21.1 or maybe even 0.21.0.1. This is probably necessary for Nix to grab the latest commit, I don't think it works directly off the branch.

Checklist:

Added the change to the "Unreleased" section of the changelog
Added some example of the new feature to the README
Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

This package is currently `spago` in NixPkgs: https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=spago The Nix configuration for that is generated from this Cabal file. Renaming to `spago-legacy` will help NixPkgs update to the new Spago. I think it's unnecessary for the `spago` binary to be renamed.

The Spago package in NixPkgs has moved from https://github.com/purescript/spago to https://github.com/purescript/spago-legacy. I believe the new `spago` https://github.com/purescript/spago is a rewrite from Haskell to PureScript. To support this new Spago in NixPkgs will probably require rewriting all of the Nix configuration. I.m.o. the easiest way to clear the path for this is to rename the old Nix configuration from `spago` to `spago-legacy`. Because part of this is generated by `cabal2nix`, changes to the `spago-legacy` Cabal file are needed: purescript/spago-legacy#3

f-f · 2024-07-06T08:39:03Z

We don't have release CI set up on this repo, so it might take more work to build the binaries. Will nixpkgs need the binaries or will it build them off the branch? In other words: will just cutting the release tag enough for nixpkgs?

peterbecich · 2024-07-06T18:58:42Z

NixPkgs will not need the binaries.

From what I can understand about this script
https://github.com/NixOS/nixpkgs/blob/9860009d87706af95eb94bc5369f86741e047135/pkgs/development/tools/purescript/spago-legacy/update.sh#L22-L31
the release bundle is necessary but you can omit the binaries. In fact, the release bundle can probably be empty. A tag without a release is insufficient. The script is going to grab the latest item in https://api.github.com/repos/purescript/spago-legacy/releases, parse the tag from that, and then cabal2nix will fetch that tag.

Thanks

f-f · 2024-07-07T10:55:46Z

Thanks, that makes sense. I can merge this PR and cut a new tag, but we'll need to get CI going first - the macOS build fails with the purescript installer failing Check if a prebuilt 0.15.8 binary is provided for darwin-arm64. Which is strange because the build is not running on an ARM machine.

peterbecich · 2024-07-13T06:46:03Z

I can disable the unnecessary jobs in .github in this PR, leaving only build ubuntu-latest and Cabal build, is that acceptable?

peterbecich · 2024-07-13T06:51:44Z

I don't think the Mac build is necessary to support the Darwin platform of the Nix build:

https://search.nixos.org/packages?channel=unstable&show=spago&from=0&size=50&sort=relevance&type=packages&query=spago
Platforms

[aarch64-darwin](https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.spago.aarch64-darwin)
[aarch64-linux](https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.spago.aarch64-linux)
[i686-linux](https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.spago.i686-linux)
[x86_64-darwin](https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.spago.x86_64-darwin)
[x86_64-linux](https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.spago.x86_64-linux)

It is going to build Spago directly from source, given the release package.

peterbecich · 2024-07-13T06:56:03Z

.github/workflows/build.yml

@@ -39,7 +39,7 @@ jobs:
      - uses: actions/checkout@v2
      - name: Setup Haskell (macOS and Windows)
        if: runner.os != 'Linux'
-        uses: haskell/actions/setup@v1
+        uses: haskell-actions/setup@v2


https://github.com/haskell-actions/setup

peterbecich · 2024-07-14T01:50:10Z

@f-f please review again

.github/workflows/release.yml

spago-legacy.cabal

peterbecich · 2024-07-20T22:18:28Z

@f-f please review again

f-f · 2024-07-28T14:22:27Z

I merged and cut the new release. Please keep me posted on the progress in nixpkgs!

I think it's unnecessary for the spago binary to be renamed to spago-legacy.

Let's do the renaming, it's quite confusing to have the two things share the same binary name.

The Spago package in NixPkgs has moved from https://github.com/purescript/spago to https://github.com/purescript/spago-legacy. I believe the new `spago` https://github.com/purescript/spago is a rewrite from Haskell to PureScript. To support this new Spago in NixPkgs will probably require rewriting all of the Nix configuration. I.m.o. the easiest way to clear the path for this is to rename the old Nix configuration from `spago` to `spago-legacy`. Because part of this is generated by `cabal2nix`, changes to the `spago-legacy` Cabal file are needed: purescript/spago-legacy#3

peterbecich · 2024-07-28T16:14:26Z

Thanks @f-f , here is the WIP NixOS/nixpkgs#324944

I will rename the binary to spago-legacy. This may require another PR and release, t.b.d.

peterbecich force-pushed the rename-package branch from 710089e to 30d0eb4 Compare July 6, 2024 02:04

peterbecich force-pushed the rename-package branch from 30d0eb4 to 02f95a4 Compare July 6, 2024 02:08

peterbecich marked this pull request as ready for review July 6, 2024 02:09

This was referenced Jul 6, 2024

haskellPackages.spago: rename to spago-legacy NixOS/nixpkgs#324944

Draft

Broken package spago NixOS/nixpkgs#253198

Closed

disable unnecessary CI jobs

f7a04f9

peterbecich force-pushed the rename-package branch from 0ec9654 to f7a04f9 Compare July 13, 2024 06:48

peterbecich force-pushed the rename-package branch from 81dfb13 to df95f0d Compare July 13, 2024 06:55

peterbecich commented Jul 13, 2024

View reviewed changes

peterbecich force-pushed the rename-package branch from df95f0d to b3a5ecc Compare July 13, 2024 06:57

fix Ubuntu CI

de6d5ce

peterbecich force-pushed the rename-package branch from b3a5ecc to de6d5ce Compare July 13, 2024 07:18

f-f reviewed Jul 14, 2024

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

spago-legacy.cabal Outdated Show resolved Hide resolved

bump version to 0.21.1, remove unneeded GitHub Action

4d7cc0e

peterbecich requested a review from f-f July 16, 2024 05:34

f-f approved these changes Jul 28, 2024

View reviewed changes

f-f merged commit 2790261 into purescript:master Jul 28, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rename package to `spago-legacy` to help NixPkgs #3

rename package to `spago-legacy` to help NixPkgs #3

peterbecich commented Jul 6, 2024 •

edited

Loading

f-f commented Jul 6, 2024 •

edited

Loading

peterbecich commented Jul 6, 2024

f-f commented Jul 7, 2024

peterbecich commented Jul 13, 2024 •

edited

Loading

peterbecich commented Jul 13, 2024 •

edited

Loading

peterbecich Jul 13, 2024

peterbecich commented Jul 14, 2024

peterbecich commented Jul 20, 2024

f-f commented Jul 28, 2024

peterbecich commented Jul 28, 2024

rename package to spago-legacy to help NixPkgs #3

rename package to spago-legacy to help NixPkgs #3

Conversation

peterbecich commented Jul 6, 2024 • edited Loading

Description of the change

Checklist:

f-f commented Jul 6, 2024 • edited Loading

peterbecich commented Jul 6, 2024

f-f commented Jul 7, 2024

peterbecich commented Jul 13, 2024 • edited Loading

peterbecich commented Jul 13, 2024 • edited Loading

peterbecich Jul 13, 2024

Choose a reason for hiding this comment

peterbecich commented Jul 14, 2024

peterbecich commented Jul 20, 2024

f-f commented Jul 28, 2024

peterbecich commented Jul 28, 2024

rename package to `spago-legacy` to help NixPkgs #3

rename package to `spago-legacy` to help NixPkgs #3

peterbecich commented Jul 6, 2024 •

edited

Loading

f-f commented Jul 6, 2024 •

edited

Loading

peterbecich commented Jul 13, 2024 •

edited

Loading

peterbecich commented Jul 13, 2024 •

edited

Loading