Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix dirty version name #309

Merged
merged 1 commit into from
Jan 19, 2024
Merged

🐛 Fix dirty version name #309

merged 1 commit into from
Jan 19, 2024

Conversation

ayushuk
Copy link
Member

@ayushuk ayushuk commented Jan 14, 2024

Summary:

This PR addresses the issue of version.py not giving a clean version number.

Motivation:

The cause is still not completely clear to me but it seems that the git clean -f command fixes the added characters that the "--dirty" flag will added when using git describe if there are local uncommitted changes. This was tried on master without luck but adding this command without the other changes to the workflow works with my new tag.

Test Plan:

  • Create a new tag on the latest commit, push the tag and check the artifacts have a clean version number
Screenshot 2024-01-14 at 1 00 27 PM Screenshot 2024-01-14 at 12 53 31 PM

@ayushuk ayushuk merged commit cc04cb7 into develop Jan 19, 2024
10 checks passed
@ayushuk ayushuk deleted the fix-version branch January 19, 2024 00:36
@ayushuk ayushuk restored the fix-version branch January 19, 2024 01:16
This was referenced Jan 19, 2024
@ayushuk ayushuk deleted the fix-version branch January 23, 2024 01:25
@ayushuk ayushuk mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant