wip ci #382
wip ci #382
Conversation
For now we want to have running CI. We do not care about the module being fully documented.
* Fix acceptance tests to work with Litmus * Fix acceptance test installation path of puppet modules * update/add dependencies to fixtures * Fix CI failures related to legacy facts * More CI fixes with latest posgresql module * Remove local facts overrides They break adding facts from a context. * Match the ensure value of the manifest This was changed in 68d8c64 to fix puppet lint issues, but as the test suite was not run it passed through. * Match owner / mode of the manifest This was changed in 010bf13 to match best practice, but as the test suite was not run it passed through. * Add path to the custom facts The systemd module use this to run `systemctl daemon-reload`. Set an arbitrary value to avoid: > Validation of Exec[systemd-postgresql.service-systemctl-daemon-reload] failed: 'systemctl' is not qualified and no path was specified. Please qualify the command or specify a path.
* patched cas module_ci workflow to disable the dependency checker
documented hack to ensure EL8 acceptance tests pass
| @@ -78,11 +78,11 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "puppet", | |||
| "version_requirement": ">= 4.10.0 < 9.0.0" | |||
| "version_requirement": ">= 7.0.0 < 9.0.0" | |||
There was a problem hiding this comment.
This drops a significant amount of major versions. Maybe that can be done in a dedicated PR so it's more present in the changelog?
There was a problem hiding this comment.
I believe that was in the squashed #344
Is this a blocker? I can't see how it would matter. No reasonable way to test on agents that old.
There was a problem hiding this comment.
if it matters depends on the CHANGELOG.md quality Puppet wants to have. For Vox Pupuli it's important to document those breaking changes. I suggest to make this change in a dedicated PR and rebase your good-times branch against it.
| } | ||
|
|
||
| describe 'puppetdb::database::read_grant' do | ||
| let(:facts) { on_supported_os.take(1).first[1] } |
There was a problem hiding this comment.
Why did you limit the tests to one OS instead of all?
There was a problem hiding this comment.
Because that's the way it was :) The change was a simple refactor to remove the let(:facts) blocks all over the spec tests.
Many of the classes, which in some cases are just resource wrappers, there is no purpose to testing all platforms.
| @@ -32,7 +32,10 @@ class { 'postgresql::server': | |||
| end | |||
|
|
|||
| describe 'manifest' do | |||
| it { is_expected.to compile.with_all_deps } | |||
| it { | |||
| pending('platform support to be removed') if facts[:os]['name'] == 'Ubuntu' && (Puppet::Util::Package.versioncmp(facts[:os]['release']['major'], '18.04') < 0) | |||
There was a problem hiding this comment.
what about dropping Ubuntu 16.04 in another PR stead of marking it as pending?
There was a problem hiding this comment.
I agree another PR is needed, and one is open.
I prefer all tests pass on this PR, which should open up merging the backlog.
* centos/oracle 7 docker hanging, cgroupsv1? * scientific 7 is just broken, no testing for you * release of postgres module is deploying expired gpg keys for all EL versions
aside from syntax, there are no puppet code changes.