Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table parsing with * in non-table names #1209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2fa
Copy link
Contributor

@2fa 2fa commented Apr 4, 2024

Summary

If iptables-save contains * in a non-table names it will break table parsing:

  1. Current table rules after encountered * will be considered absent and will be forcefully added on every puppet run without duplicate checks (cuz puppet thinks that there are no more rules in that table)
  2. Next table will be skipped completely.

Additional Context

We need to have more iptables-save parsing tests, there are more bugs at rule level as well (i will open PR tomorrow)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@2fa 2fa requested a review from a team as a code owner April 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants