Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "(maint) Exclude breaking rubocop versions" #570

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

gavindidrichsen
Copy link
Contributor

Reverts #565

Signed-off-by: Gavin Didrichsen <[email protected]>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (a16cc96) to head (d1f606e).

Files Patch % Lines
lib/puppet_litmus/rake_helper.rb 50.00% 2 Missing ⚠️
lib/puppet_litmus/inventory_manipulation.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   63.95%   64.03%   +0.07%     
==========================================
  Files           6        6              
  Lines         763      759       -4     
==========================================
- Hits          488      486       -2     
+ Misses        275      273       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavindidrichsen gavindidrichsen marked this pull request as ready for review June 20, 2024 13:01
@gavindidrichsen gavindidrichsen requested a review from a team as a code owner June 20, 2024 13:01
@gavindidrichsen
Copy link
Contributor Author

As I didn't add any functionality here but only correct syntax on existing code, I'm recommending we

Signed-off-by: Gavin Didrichsen <[email protected]>
@gavindidrichsen gavindidrichsen force-pushed the revert-565-maint_exclude_rubocop_versions branch from 860f3c8 to d1f606e Compare June 20, 2024 13:08
@david22swan david22swan merged commit c0f2e80 into main Jun 20, 2024
5 of 6 checks passed
@david22swan david22swan deleted the revert-565-maint_exclude_rubocop_versions branch June 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants