Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1688) - Pin rubocop to ~> 1.50.0 #541

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

LukasAud
Copy link
Contributor

Following a recent team decision, we are implementing a Rubocop Upgrade moving the version from 1.48.1 to 1.50.0. This should be the final version until Puppet 7 is unsupported.

Following a recent team decision, we are implementing a Rubocop Upgrade
moving the version from 1.48.1 to 1.50.0. This should be the final
version until Puppet 7 is unsupported.
@LukasAud LukasAud requested a review from a team as a code owner January 19, 2024 11:34
@codecov-commenter
Copy link

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (8db22fd) 64.66% compared to head (703a172) 61.64%.
Report is 159 commits behind head on main.

Files Patch % Lines
lib/puppet_litmus/puppet_helpers.rb 77.02% 34 Missing ⚠️
lib/puppet_litmus/rake_tasks.rb 15.00% 17 Missing ⚠️
lib/puppet_litmus/rake_helper.rb 85.52% 11 Missing ⚠️
lib/puppet_litmus/inventory_manipulation.rb 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   64.66%   61.64%   -3.02%     
==========================================
  Files           7        6       -1     
  Lines         917      764     -153     
==========================================
- Hits          593      471     -122     
+ Misses        324      293      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 merged commit 30cedba into main Jan 22, 2024
6 checks passed
@jordanbreen28 jordanbreen28 deleted the CAT-1688-Upgrade_rubocop branch January 22, 2024 09:30
@jordanbreen28 jordanbreen28 changed the title (CAT-1688) Upgrade Rubocop (CAT-1688) - Pin rubocop to ~> 1.50.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants